Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifted pin on sqlalchemy in order to be able to use v2+ #1832

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ricardogsilva
Copy link
Member

Overview

This PR lifts the pin on the sqlalchemy dependency, removing the requirement to use a version lower than v2.

Related Issue / discussion

Additional information

WRT RFC2, and as mentioned in my previous comment at the issue:

#1661 (comment)

The current code base should be compatible with both sqlalchemy v1.4 (which is what is included in current ubuntu LTS repos) and with v2, which means we can continue to use v1.4 from the current ubuntu LTS repos when doing a 'bare metal' install and also means we can use the current version of sqlalchemy when installing via other methods, like pip.

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@ricardogsilva ricardogsilva marked this pull request as ready for review October 21, 2024 12:51
@ricardogsilva
Copy link
Member Author

@tomkralidis CI error seems unrelated to the changes in the PR - seems like some trivy limit has been reached. I think it would likely go away if the job is re-run. I am not able to ask for a re-run of the failed CI JOB though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant