-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] allow to open COG links in mapstore #252
[feat] allow to open COG links in mapstore #252
Conversation
geonetwork/core-geonetwork#7387 was merged upstream (squashed commit in geonetwork/core-geonetwork@123db88a0), so this one can be merged now i think ? @fvanderbiest ? |
Thanks Landry ! M merged on 4.4, which will not be part of geOrchestra in the short term. |
no problem i can rebase the PR (and #227 which was also merged upstream) on top of 4.2.6 once its been merged/rebased in georchestra/geonetwork. |
d0f7d30
to
59a5dbc
Compare
PR rebased on top of #260, has been already merged upstream but in the 4.4 branch |
902e86a
to
1353217
Compare
* add OGC:COG to possible values for gmd:protocol * add support to open OGC:COG links in the external viewer * show an alert saying COG/3DTiles is not supported yet This will also avoid switching to the viewer if no layer with supported protocol is found --------- Co-authored-by: Olivia <[email protected]>
59a5dbc
to
ee5ea44
Compare
rebased the PR to be just the upstream squashed commit (geonetwork/core-geonetwork@123db88a0) on top of tested successfully on 4.2.2, clicking on a 3dtiles or cog link in a MD opens the layer in mapstore, and clicking back in the browser correctly comes back to the MD view. |
8af78f2
to
8765a1d
Compare
much like #227 and vastly inspired by it, mapstore2 is getting COG native support in 2023.02 (cf georchestra/mapstore2-georchestra#338), and i'm working upstream on support for parametrized opening of COG links in mapstore2 in geosolutions-it/MapStore2#9531
with this PR, i'm able to open links from GN4 in my dev MS2 instance, using the same url template for the external viewer.
the MD has the new COG format (i've chosen OGC:COG as it's a candidate to OGC standards cf https://portal.ogc.org/files/102116) among the other available link types:
in the XML i have this:
and the opened link has this queryparams:
?actions=[{"type":"CATALOG:ADD_LAYERS_FROM_CATALOGS","layers":["Vichy 3cm"],"sources":[{"type":"cog","url":"https%3A%2F%2Fcogeo.craig.fr%2Fopendata%2Fortho%2Forthocraig3_vichy_2021.cog.tif"}]}]
title is correctly set from the
gmd:name
value:will ofc push the two commits upstream