-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix CSW GetRecords issue from mapstore #253
Conversation
aa75494
to
79b3fcd
Compare
I had a talk with @cmangeat who told me that his "heroïc fix" is heroïc in the sense we should definitely not do it this way. |
I see it has been fixed upstream on 4.2.6, which we are upgrading to on geOrchestra master. The current PR on the branch targeted by geOrchestra master can be discarded IMO. |
* Revert #253 * CSW GetRecords doesn't escape query values when creating the Elasticsearch query. Fixes #7527 * CSW GetRecords doesn't escape query values when creating the Elasticsearch query / Escape Elasticsearch special chars in EQUAL / NOT EQUAL literal queries * CSW GetRecords doesn't escape query values when creating the Elasticsearch query / Escape Elasticsearch special chars in IS LIKE literal queries * Reset geotools usage and comments tests --------- Co-authored-by: Jose García <[email protected]>
* Revert #253 * CSW GetRecords doesn't escape query values when creating the Elasticsearch query. Fixes #7527 * CSW GetRecords doesn't escape query values when creating the Elasticsearch query / Escape Elasticsearch special chars in EQUAL / NOT EQUAL literal queries * CSW GetRecords doesn't escape query values when creating the Elasticsearch query / Escape Elasticsearch special chars in IS LIKE literal queries * Reset geotools usage and comments tests --------- Co-authored-by: Jose García <[email protected]>
* Revert #253 * CSW GetRecords doesn't escape query values when creating the Elasticsearch query. Fixes #7527 * CSW GetRecords doesn't escape query values when creating the Elasticsearch query / Escape Elasticsearch special chars in EQUAL / NOT EQUAL literal queries * CSW GetRecords doesn't escape query values when creating the Elasticsearch query / Escape Elasticsearch special chars in IS LIKE literal queries * Reset geotools usage and comments tests --------- Co-authored-by: Jose García <[email protected]>
On current georchestra's geonetwork version (based of GN4.2), the following payload on the CSW endpoint (generated from the mapstore UI when trying to add a layer from the local catalogue) is translated to an invalid query sent to Elasticsearch:
It turns out it works if the purl.org url is double-quoted. @cmangeat already provided a fix into an "unofficial" branch from this repository. This PR is just about cherry-picking the work and attempt to fix the IT testsuite.