feat: adding OGC API Feat. to external link for 19115-3 #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahow
approved these changes
Nov 27, 2023
jahow
reviewed
Dec 5, 2023
| "isMultilingual": false | ||
| }, | ||
| "protocol": { | ||
| "value": "OGC API - Features", |
There was a problem hiding this comment.
I have thought again about this value here; I think it would at least be better to align with the "official" values that should land in GeoNetwork soon, see geonetwork/core-geonetwork#7468
The value should then be OGC API Features instead of OGC API - Features. Otherwise records in geOrchestra might not be correctly understood once the PR above is merged.
Sorry for not picking that up earlier 😕
There was a problem hiding this comment.
Thanks @jahow !
We'll take care of updating this locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to add external link to OGC API - Features for the 19115-3 and 19139 iso.
geonetwork/core-geonetwork#7474