Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override only desc and name on role based sync #301

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

f-necas
Copy link
Collaborator

@f-necas f-necas commented Aug 9, 2024

Used to override only name and description when group sync is set to roles.

It avoids to override/delete information set in geonetwork like image, email and website.

geOrchestra/geonetwork checklist

  • PR only involves cherry-picked commits from upstream.
  • PR contains custom code which will soon be available in an upstream release and can be overriden => mention core-geonetwork version if possible.
  • PR contains custom geOrchestra code, which need to be verified during future migrations.

@f-necas f-necas changed the title fix: override only desc and name on role based sync Override only desc and name on role based sync Aug 9, 2024
@f-necas f-necas requested a review from landryb August 9, 2024 15:20
@landryb
Copy link
Member

landryb commented Aug 12, 2024

at first i was confused, then i realized this was for role based sync, which dont have logos/urls... so that makes sense to me :)

@f-necas f-necas merged commit 3db6bfa into georchestra-gn4.4.x Aug 12, 2024
1 check passed
@f-necas f-necas deleted the fix-role-based-sync branch August 12, 2024 09:13
@f-necas f-necas added this to the 24.0.1 milestone Aug 12, 2024
github-actions bot added a commit that referenced this pull request Aug 12, 2024
…-23.0.x/pr-301

[georchestra-gn4.2.x-23.0.x] Merge pull request #301 from georchestra/fix-role-based-sync
Copy link

💚 All backports created successfully

Status Branch Result
georchestra-gn4.2.x-23.0.x
georchestra-gn4.2.x-24.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

github-actions bot added a commit that referenced this pull request Aug 12, 2024
…-24.0/pr-301

[georchestra-gn4.2.x-24.0] Merge pull request #301 from georchestra/fix-role-based-sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants