This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
Issue 128 hyperparam #143
Merged
Issue 128 hyperparam #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. extending the _get_param_names and fixing the class to be parents in the wrapper. 2. Fixing PreparerStep to traverse __mro__. 3. Double checking major classes to ensure get_params returns required values. Tests included.
…tners/foreshadow into issue_128_hyperparam # Conflicts: # foreshadow/smart/smart.py updating poetry
…s for our use case. Using patchy to implement this. Switching all imports to use our internal BaseEstimator and TransformerMixin. Adding Smart test.
# Conflicts: # foreshadow/base.py
IMPORTANT: cHanges to preparerstep and to DataPreparer to enable from initialization from set_params.
IMPORTANT: Changes to preparerstep and to DataPreparer to enable from initialization from set_params.
jzhang-gp
reviewed
Aug 22, 2019
foreshadow/tests/test_transformers/test_concrete/test_cleaners/test_data_cleaner.py
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable manual hyperparameter tuning via serialized objects.
Enable future use of automated tuning.
Includes ParamSpec, which holds 1 search space (a run of optimization of the different choices of that search space).
SearchOptimizer which holds all search spaces and the algorithms used to search in them.