[TASK] Remove not needed TCA config internal_type (#2169)

In TYPO3v11 'db' is the default setting, in v12 it is deprecated and not evaluated anymore. Co-authored-by: GM <[email protected]>
georgringer · Aug 5, 2023 · a813980 · a813980
1 parent 60487e8
commit a813980
Show file tree

Hide file tree

Showing 12 changed files with 0 additions and 46 deletions.
diff --git a/Configuration/FlexForms/flexform_category_list.xml b/Configuration/FlexForms/flexform_category_list.xml
@@ -54,7 +54,6 @@
 							<label>LLL:EXT:core/Resources/Private/Language/locallang_general.xlf:LGL.startingpoint</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>3</size>
 								<maxitems>50</maxitems>
@@ -126,7 +125,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.listPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>

diff --git a/Configuration/FlexForms/flexform_news.xml b/Configuration/FlexForms/flexform_news.xml
@@ -307,7 +307,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_general.singleNews</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>tx_news_domain_model_news</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -349,7 +348,6 @@
 							<label>LLL:EXT:core/Resources/Private/Language/locallang_general.xlf:LGL.startingpoint</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>3</size>
 								<maxitems>50</maxitems>
@@ -405,7 +403,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_general.selectedList</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>tx_news_domain_model_news</allowed>
 								<size>5</size>
 							</config>
@@ -435,7 +432,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.detailPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -450,7 +446,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.listPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -465,7 +460,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.backPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -504,7 +498,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.tags</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>tx_news_domain_model_tag</allowed>
 								<size>3</size>
 								<minitems>0</minitems>

diff --git a/Configuration/FlexForms/flexform_news_date_menu.xml b/Configuration/FlexForms/flexform_news_date_menu.xml
@@ -190,7 +190,6 @@
 							<label>LLL:EXT:core/Resources/Private/Language/locallang_general.xlf:LGL.startingpoint</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>3</size>
 								<maxitems>50</maxitems>
@@ -262,7 +261,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.detailPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -277,7 +275,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.listPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -292,7 +289,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.backPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>

diff --git a/Configuration/FlexForms/flexform_news_detail.xml b/Configuration/FlexForms/flexform_news_detail.xml
@@ -19,7 +19,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_general.singleNews</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>tx_news_domain_model_news</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -61,7 +60,6 @@
 							<label>LLL:EXT:core/Resources/Private/Language/locallang_general.xlf:LGL.startingpoint</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>3</size>
 								<maxitems>50</maxitems>
@@ -133,7 +131,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.detailPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -148,7 +145,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.backPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>

diff --git a/Configuration/FlexForms/flexform_news_list.xml b/Configuration/FlexForms/flexform_news_list.xml
@@ -275,7 +275,6 @@
 							<label>LLL:EXT:core/Resources/Private/Language/locallang_general.xlf:LGL.startingpoint</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>3</size>
 								<maxitems>50</maxitems>
@@ -347,7 +346,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.detailPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -362,7 +360,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.listPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -377,7 +374,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.backPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -416,7 +412,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.tags</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>tx_news_domain_model_tag</allowed>
 								<size>3</size>
 								<minitems>0</minitems>

diff --git a/Configuration/FlexForms/flexform_news_search_form.xml b/Configuration/FlexForms/flexform_news_search_form.xml
@@ -20,7 +20,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.listPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -35,7 +34,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.tags</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>tx_news_domain_model_tag</allowed>
 								<size>3</size>
 								<minitems>0</minitems>

diff --git a/Configuration/FlexForms/flexform_news_selected_list.xml b/Configuration/FlexForms/flexform_news_selected_list.xml
@@ -19,7 +19,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_general.selectedList</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>tx_news_domain_model_news</allowed>
 								<size>3</size>
 								<minitems>1</minitems>
@@ -110,7 +109,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.detailPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -125,7 +123,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.listPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -140,7 +137,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.backPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -179,7 +175,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.tags</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>tx_news_domain_model_tag</allowed>
 								<size>3</size>
 								<minitems>0</minitems>

diff --git a/Configuration/FlexForms/flexform_tag_list.xml b/Configuration/FlexForms/flexform_tag_list.xml
@@ -73,7 +73,6 @@
 							<label>LLL:EXT:core/Resources/Private/Language/locallang_general.xlf:LGL.startingpoint</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>3</size>
 								<maxitems>50</maxitems>
@@ -143,7 +142,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.listPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -158,7 +156,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.backPid</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>pages</allowed>
 								<size>1</size>
 								<maxitems>1</maxitems>
@@ -174,7 +171,6 @@
 							<label>LLL:EXT:news/Resources/Private/Language/locallang_be.xlf:flexforms_additional.tags</label>
 							<config>
 								<type>group</type>
-								<internal_type>db</internal_type>
 								<allowed>tx_news_domain_model_tag</allowed>
 								<size>3</size>
 								<minitems>0</minitems>

diff --git a/Configuration/TCA/Overrides/sys_category.php b/Configuration/TCA/Overrides/sys_category.php
@@ -88,7 +88,6 @@
         'label' => $ll . 'tx_news_domain_model_category.single_pid',
         'config' => [
             'type' => 'group',
-            'internal_type' => 'db',
             'allowed' => 'pages',
             'size' => 1,
             'maxitems' => 1,
@@ -108,7 +107,6 @@
         'label' => $ll . 'tx_news_domain_model_category.shortcut',
         'config' => [
             'type' => 'group',
-            'internal_type' => 'db',
             'allowed' => 'pages',
             'size' => 1,
             'maxitems' => 1,

diff --git a/Configuration/TCA/Overrides/z_misc_12_adoptions.php b/Configuration/TCA/Overrides/z_misc_12_adoptions.php
@@ -41,13 +41,6 @@
             ],
         ];
 
-        // internal type
-        foreach (['sys_category' => ['single_pid', 'shortcut'], 'tx_news_domain_model_news' => ['l10n_parent', 'related_from', 'related']] as $table => $fields) {
-            foreach ($fields as $field) {
-                unset($GLOBALS['TCA'][$table]['columns'][$field]['config']['internal_type']);
-            }
-        }
-
         // required fields
         foreach (['tx_news_domain_model_link' => ['uri'], 'tx_news_domain_model_news' => ['title', 'externalurl'], 'tx_news_domain_model_tag' => ['title']] as $table => $fields) {
             foreach ($fields as $field) {

diff --git a/Configuration/TCA/tx_news_domain_model_news.php b/Configuration/TCA/tx_news_domain_model_news.php
@@ -168,7 +168,6 @@
             'label' => 'LLL:EXT:core/Resources/Private/Language/locallang_general.xlf:LGL.l18n_parent',
             'config' => [
                 'type' => 'group',
-                'internal_type' => 'db',
                 'allowed' => 'tx_news_domain_model_news',
                 'size' => 1,
                 'maxitems' => 1,
@@ -408,7 +407,6 @@
             'label' => $ll . 'tx_news_domain_model_news.related',
             'config' => [
                 'type' => 'group',
-                'internal_type' => 'db',
                 'allowed' => 'tx_news_domain_model_news',
                 'foreign_table' => 'tx_news_domain_model_news',
                 'MM_opposite_field' => 'related_from',
@@ -432,7 +430,6 @@
             'label' => $ll . 'tx_news_domain_model_news.related_from',
             'config' => [
                 'type' => 'group',
-                'internal_type' => 'db',
                 'foreign_table' => 'tx_news_domain_model_news',
                 'allowed' => 'tx_news_domain_model_news',
                 'size' => 5,

diff --git a/Documentation/Tutorials/ExtendNews/ExtensionBasedOnNews/Index.rst b/Documentation/Tutorials/ExtendNews/ExtensionBasedOnNews/Index.rst
@@ -262,7 +262,6 @@ The syntax of ``FlexForms`` is identical to the one of ``TCA`` with the only dif
                         <label>LLL:EXT:core/Resources/Private/Language/locallang_general.xlf:LGL.startingpoint</label>
                         <config>
                            <type>group</type>
-                           <internal_type>db</internal_type>
                            <allowed>pages</allowed>
                            <size>3</size>
                            <maxitems>50</maxitems>