-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delete layer method and tests in doc #583
Conversation
I don't think the CI fail is from my changes. Any idea what to do? |
The CI error says this:
|
You can just comment out https://github.com/georust/gdal/blob/master/.github/workflows/ci.yml#L28. It looks like |
ab256d3
to
c17bd76
Compare
c17bd76
to
f310548
Compare
f310548
to
2d50a35
Compare
2d50a35
to
d5ee894
Compare
IDK why, commenting the line got me |
d5ee894
to
bd1db4c
Compare
I squashed all commits, so it's easier to merge. This should be done now (once CI passes). |
Co-authored-by: Laurențiu Nicola <[email protected]>
I'll merge this after you squash. EDIT: nvm. |
CHANGES.md
if knowledge of this change could be valuable to users.I noticed this was not present, so I just added a crude implementation. Might be nice to add
delete_layer_by_name
option as well.If there are more unimplemented methods, we can add as well.