Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete layer method and tests in doc #583

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

Atreyagaurav
Copy link
Contributor

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

I noticed this was not present, so I just added a crude implementation. Might be nice to add delete_layer_by_name option as well.

If there are more unimplemented methods, we can add as well.

@Atreyagaurav Atreyagaurav marked this pull request as ready for review November 1, 2024 23:27
@Atreyagaurav
Copy link
Contributor Author

I don't think the CI fail is from my changes. Any idea what to do?

@Atreyagaurav
Copy link
Contributor Author

Atreyagaurav commented Nov 2, 2024

The CI error says this:

 --- stderr
  thread 'main' panicked at gdal-sys/build.rs:250:17:
  No pre-built bindings available for GDAL version 3.11. Enable the `bindgen` feature of the `gdal` or `gdal-sys` crate to generate them during build.

@lnicola
Copy link
Member

lnicola commented Nov 2, 2024

You can just comment out https://github.com/georust/gdal/blob/master/.github/workflows/ci.yml#L28. It looks like -latest is now 3.11.0, but 3.10 hasn't been published yet 😒.

Atreyagaurav added a commit to Atreyagaurav/gdal that referenced this pull request Nov 2, 2024
Atreyagaurav added a commit to Atreyagaurav/gdal that referenced this pull request Nov 2, 2024
Atreyagaurav added a commit to Atreyagaurav/gdal that referenced this pull request Nov 2, 2024
Atreyagaurav added a commit to Atreyagaurav/gdal that referenced this pull request Nov 2, 2024
Atreyagaurav added a commit to Atreyagaurav/gdal that referenced this pull request Nov 2, 2024
@Atreyagaurav
Copy link
Contributor Author

IDK why, commenting the line got me Invalid workflow file error, and CI didn't run. I tried a few alternative way to comment, thinking indent might have done it. I don't understand it, so for now I just removed the -latest line, Please remember to add it and 3.10.0 later.

@Atreyagaurav
Copy link
Contributor Author

I squashed all commits, so it's easier to merge. This should be done now (once CI passes).

src/vector/layer.rs Outdated Show resolved Hide resolved
Co-authored-by: Laurențiu Nicola <[email protected]>
@lnicola
Copy link
Member

lnicola commented Nov 3, 2024

I'll merge this after you squash. EDIT: nvm.

@lnicola lnicola merged commit 0644110 into georust:master Nov 3, 2024
12 checks passed
@Atreyagaurav Atreyagaurav deleted the new-methods branch November 3, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants