Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CoordsIter trait with GATs by removing an unneeded trait lifetime #908

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Simplify CoordsIter trait with GATs by removing an unneeded trait lifetime #908

merged 3 commits into from
Sep 25, 2023

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Sep 14, 2022 •
edited
Loading

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

rust-lang/rust#44265

@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 3, 2022

GAT's are now in stable Rust. So this can be ready whenever we want to update our MSRV

https://blog.rust-lang.org/2022/11/03/Rust-1.65.0.html

@frewsxcv frewsxcv marked this pull request as ready for review November 3, 2022 16:20
@frewsxcv frewsxcv changed the title Simplify CoordsIter trait with GATs. Simplify CoordsIter trait with GATs by removing an unneeded trait lifetime Nov 3, 2022
@martinfrances107 martinfrances107 mentioned this pull request Jan 13, 2023
Open
@frewsxcv frewsxcv marked this pull request as draft January 19, 2023 03:54
michaelkirk
michaelkirk approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@michaelkirk michaelkirk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.65 was released about 9 months ago. Given our MSRV >= CURRENT - 3 (about 6 months), I'd say we should go for it and bump to 1.65.

IIRC there can be some nice downstream cleanups for traits implemented in terms of CoordsIter like ConvexHull.

@michaelkirk michaelkirk mentioned this pull request Sep 21, 2023
Merged
2 tasks
@frewsxcv frewsxcv marked this pull request as ready for review September 25, 2023 20:02
@michaelkirk michaelkirk added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit ccdbe19 Sep 25, 2023
14 checks passed
@michaelkirk michaelkirk deleted the frewsxcv-gat branch September 25, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkirk michaelkirk michaelkirk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frewsxcv @michaelkirk