Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundling support on windows #192

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

weiznich
Copy link
Contributor

We need to always build release builds there (to prevent linker errors due to mixing up debug and release runtimes) and we need an additional flag to prevent the static library to expect some proj.dll file to exist

@weiznich
Copy link
Contributor Author

@urschrei @michaelkirk @lnicola What is required to move this forward? This is required for windows support of georust/gdal#517

Copy link
Member

@urschrei urschrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test this on msvc myself, but this seems uncontroversial to me.

@urschrei
Copy link
Member

Sorry for the delay on this @weiznich. I need to figure out why the CI check hasn't run – could you rebase against main?

We need to always build release builds there (to prevent linker errors
due to mixing up debug and release runtimes) and we need an additional
flag to prevent the static library to expect some proj.dll file to exist
Copy link
Member

@lnicola lnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was away last week. I'm not a fan of how this looks (wrapping, capitalization), but the change makes sense.

@urschrei urschrei added this pull request to the merge queue May 13, 2024
Merged via the queue into georust:main with commit 57c9e80 May 13, 2024
28 checks passed
urschrei pushed a commit to kylebarron/proj that referenced this pull request Jul 1, 2024
We need to always build release builds there (to prevent linker errors
due to mixing up debug and release runtimes) and we need an additional
flag to prevent the static library to expect some proj.dll file to exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants