New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support parse POINTZ, POINTM and POINTZM #113

Merged

michaelkirk merged 1 commit into georust:main from ariesdevil:dev

Jun 21, 2024

Contributor

ariesdevil commented Feb 7, 2024

I agree to follow the project's code of conduct.
I added an entry to CHANGES.md if knowledge of this change could be valuable to users.
I ran cargo fmt

ariesdevil mentioned this pull request

feat(geo): support geometry type for create table databendlabs/databend#14615

Merged

11 tasks

lnicola reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

lnicola reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

ariesdevil force-pushed the dev branch 2 times, most recently from aafbc8c to eed7f42 Compare

February 7, 2024 11:02

lnicola reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

Member

lnicola commented Feb 7, 2024

I guess this will make the conversion to geo-types lossy. I don't think Z/M are available there, so there's not much you can do, just wanted to point that out.

Contributor Author

ariesdevil commented Feb 7, 2024

I guess this will make the conversion to geo-types lossy. I don't think Z/M are available there, so there's not much you can do, just wanted to point that out.↳

Thanks point it out, I see Coord in geo-types only support x and y, I think it needs to be refactored later.

lnicola reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

ariesdevil force-pushed the dev branch from eed7f42 to ae27482 Compare

February 7, 2024 11:20

lnicola reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

lnicola reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

ariesdevil force-pushed the dev branch from ae27482 to 587ed6e Compare

February 7, 2024 11:28

Contributor Author

ariesdevil commented Feb 7, 2024

Fixed, PTAL again.

lnicola approved these changes

View reviewed changes

Member

lnicola left a comment

You didn't add that comment about matches!, but whatever 😀.

Contributor Author

ariesdevil commented Feb 7, 2024

You didn't add that comment about matches!, but whatever 😀.↳

Sorry, I forgot it🤔


          Support parse POINTZ, POINTM and POINTZM

6c83a19

ariesdevil force-pushed the dev branch from 587ed6e to 6c83a19 Compare

February 8, 2024 03:44

michaelkirk approved these changes

View reviewed changes

Member

michaelkirk left a comment

Sorry that this sat here so long!

michaelkirk merged commit 2f1f44f into georust:main

ariesdevil deleted the dev branch

June 22, 2024 16:36

Member

michaelkirk commented Jul 17, 2024 •

edited

Loading

We've misspelled POINT Z, POINT M, and POINT ZM. See #114

Can you take a look @ariesdevil?

Otherwise I think we should revert this.

michaelkirk mentioned this pull request

Correct docs that WKT ZM support is write only georust/geozero#219

Closed

kylebarron mentioned this pull request

3D point is spelled POINT Z not POINTZ #114

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet