Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset #432

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Offset #432

merged 2 commits into from
Sep 30, 2021

Conversation

KaiVolland
Copy link
Contributor

Description

This adds support for the offset field for the IconSymbolizer and the MarkSymbolizer.
In ol this is named displacment for the ImageStyle which is kind of inconsistent to the TextStyle where there are two properties offsetX and offsetY.

This also changes the dependabot interval from daily to weekly.

Related issues or pull requests

Please list issues or pull requests that the changes you propose are related to. It does not matter if they are still open and/or unmerged, any link is appreciated.

Pull request type

Please check the type of change your PR introduces:

  • Feature

Do you introduce a breaking change?

  • No

@KaiVolland KaiVolland merged commit b24431e into geostyler:master Sep 30, 2021
@yang6626
Copy link

hi there
new to here. may i ask a question about text offset, the DisplacementY is negative value(like -20) in my sld style , and the text show below the point(the style i want), but when i use this parser to parse the sld to openlayer style and set to the layer, the text show above the point.. how can i deal these differences? thanks in advance @KaiVolland @hwbllmnn

@KaiVolland
Copy link
Contributor Author

Hey @yang6626 it seems like this is an issue in the SLD parser.

The geostyler-style and openlayers handle the offset just like you described, but the SLD Standard interprets negative Y values the opposite way.

I'll create an issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants