Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guessing sld version from file directly and not setting sldVersion as option #925

Closed
pprev94 opened this issue Jun 14, 2024 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request

Comments

@pprev94
Copy link
Contributor

pprev94 commented Jun 14, 2024

Today the parser takes an SLD Version as a parameter.
If the parameter is not set, the default value is 1.0.0.
It would be a lot more practical to have the parser guess the version from the SLD content itself.

When file content is parsed, the object sldObject contains already version :

sldObject[0][":@"]["@_version"]

if this version is not authorized, an error is thrown. If the version is recognized, it can be set using set sldVersion.

@slafayIGN slafayIGN added the enhancement New feature or request label Jun 14, 2024
pprev94 added a commit that referenced this issue Jun 18, 2024
@jansule
Copy link
Contributor

jansule commented Jun 19, 2024

solved in #926

@jansule jansule closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants