issues 901 changes #616
Open
issues 901 changes #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd singlechar and escape.
KaiVolland
reviewed
Dec 8, 2023
There was a problem hiding this comment.
Thanks for your contribution @rajsync. 🙏 This looks already promising.
I'm not sure how we want to implement default values as this is repo contains just a type definition.
Maybe we can force the parsers (via StyleParser Interface) to contain defaultLikeAttributes (just an idea).
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "geostyler-style", | |||
| "version": "8.1.0", | |||
| "version": "8.2.0", | |||
There was a problem hiding this comment.
This is done by the pipelines. You don't have to care about it. So please revert to 8.1.0. :)
Comment on lines
+8
to
+12
| export interface LikeAttributes { | ||
| wildCard: string; | ||
| singleChar: string; | ||
| escape: string; | ||
| } |
There was a problem hiding this comment.
I think an array like structure would fit the geostyler-style more. e.g.:
Suggested change
| export interface LikeAttributes { | |
| wildCard: string; | |
| singleChar: string; | |
| escape: string; | |
| } | |
| /** | |
| * The LikeAttributes describe the behaviour of the {@link LikeFilter}. | |
| * [ | |
| * wildcard, (default should be `*`), | |
| * singleChar, (default should be `.`), | |
| * escape, (default should be `!`), | |
| * ] | |
| */ | |
| export interface LikeAttributes [string, string, string]; |
... this was just written freestyle on github so its just for orientation. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently wildcard, singleChar and escape values are hard coded.
provided option to pass wildcard, singleChar and escape values, while creating comparison filter 'PropertyIsLike'