-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Scala 2.12 #155
base: master
Are you sure you want to change the base?
Move to Scala 2.12 #155
Conversation
01fd97b
to
d2d6fb4
Compare
7adfe2a
to
ca99297
Compare
CircleCI was fighting me on this. I believe it was failing to properly load paradise macros, and giving a misleading compiler error as a result:
However, I could not reproduce the error anywhere else, and paradise macros were included properly. (I later discovered these same errors while trying to streamline the It may have been possible to make circle work, but I opted to move to Github actions for CI and deployment, following the template provided by locationtech/geotrellis#3440. The setup is similar to Circle, and doesn't require integration with an external service. |
I believe that this PR is stalled for the moment because moving to GT 3.7 is going to require an upgrade to Spark 3, which means that the data sources will need to be updated to use the V3 spark SQL data source API. This will require some amount of fuss, which we don't have time for at the moment. |
Overview
This PR updates the scala version to 2.12 and any required dependencies to enable this upgrade.
Checklist