Merge pull request cake-build#3998 from devlead/feature/cake-buildgh-…

…3997 GH3997: Remove obsolete DotNetTestSettings Logger property
gep13 · Oct 20, 2022 · a7fa100 · a7fa100
2 parents ca6699c + 77ed790
commit a7fa100
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 19 deletions.
diff --git a/src/Cake.Common.Tests/Unit/Tools/DotNet/Test/DotNetTesterTests.cs b/src/Cake.Common.Tests/Unit/Tools/DotNet/Test/DotNetTesterTests.cs
@@ -132,9 +132,6 @@ public void Should_Add_Additional_Settings()
                 fixture.Settings.Settings = "./demo.runsettings";
                 fixture.Settings.Filter = "Priority = 1";
                 fixture.Settings.TestAdapterPath = @"/Working/custom-test-adapter";
-#pragma warning disable CS0618
-                fixture.Settings.Logger = "trx;LogFileName=/Working/logfile.trx";
-#pragma warning restore CS0618
                 fixture.Settings.Loggers = new[] { "html;LogFileName=/Working/logfile.html" };
                 fixture.Settings.DiagnosticFile = "./artifacts/logging/diagnostics.txt";
                 fixture.Settings.ResultsDirectory = "./tests/";
@@ -147,7 +144,7 @@ public void Should_Add_Additional_Settings()
                 var result = fixture.Run();
 
                 // Then
-                Assert.Equal("test --settings \"/Working/demo.runsettings\" --filter \"Priority = 1\" --test-adapter-path \"/Working/custom-test-adapter\" --logger \"trx;LogFileName=/Working/logfile.trx\" --logger \"html;LogFileName=/Working/logfile.html\" --output \"/Working/artifacts\" --framework dnxcore50 --configuration Release --collect \"XPlat Code Coverage\" --diag \"/Working/artifacts/logging/diagnostics.txt\" --no-build --no-restore --nologo --results-directory \"/Working/tests\" --logger trx;LogFileName=\"/Working/tests/TestResults.xml\" --runtime win-x64 --source \"https://api.nuget.org/v3/index.json\" --blame", result.Args);
+                Assert.Equal("test --settings \"/Working/demo.runsettings\" --filter \"Priority = 1\" --test-adapter-path \"/Working/custom-test-adapter\" --logger \"html;LogFileName=/Working/logfile.html\" --output \"/Working/artifacts\" --framework dnxcore50 --configuration Release --collect \"XPlat Code Coverage\" --diag \"/Working/artifacts/logging/diagnostics.txt\" --no-build --no-restore --nologo --results-directory \"/Working/tests\" --logger trx;LogFileName=\"/Working/tests/TestResults.xml\" --runtime win-x64 --source \"https://api.nuget.org/v3/index.json\" --blame", result.Args);
             }
 
             [Fact]

diff --git a/src/Cake.Common/Tools/DotNet/Test/DotNetTestSettings.cs b/src/Cake.Common/Tools/DotNet/Test/DotNetTestSettings.cs
@@ -31,12 +31,6 @@ public class DotNetTestSettings : DotNetSettings
         /// </summary>
         public DirectoryPath TestAdapterPath { get; set; }
 
-        /// <summary>
-        /// Gets or sets a logger for test results.
-        /// </summary>
-        [Obsolete("Please use Loggers instead.")]
-        public string Logger { get; set; }
-
         /// <summary>
         /// Gets or sets the loggers for test results.
         /// </summary>

diff --git a/src/Cake.Common/Tools/DotNet/Test/DotNetTester.cs b/src/Cake.Common/Tools/DotNet/Test/DotNetTester.cs
@@ -81,15 +81,6 @@ private ProcessArgumentBuilder GetArguments(string project, ProcessArgumentBuild
                 builder.AppendQuoted(settings.TestAdapterPath.MakeAbsolute(_environment).FullPath);
             }
 
-            // Logger
-#pragma warning disable CS0618
-            if (!string.IsNullOrWhiteSpace(settings.Logger))
-            {
-                builder.Append("--logger");
-                builder.AppendQuoted(settings.Logger);
-            }
-#pragma warning restore CS0618
-
             // Loggers
             if (settings.Loggers != null)
             {