v4 dev: revises *window, bound*, default* and prev/next session/minute methods.
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revises following `ExchangeCalendar` methods, and associated tests, so that `count` parameter reflects window length (previously window length was `count` + 1): - `sessions_window`. - `minutes_window`. Also changes methods' parameter names: - `start_dt` renamed `minute`. - `session_label` renamed `session`.
Changes error raised when prev or next minute or session is out-of-bounds. Changed from `ValueError` to `Requested*OutOfBounds`. Simplifies minute_to_*_session methods.
Changes `ExchangeCalendar` bound* and default* properties to class methods. To support change also makes `PrecomputedExchangeCalendar.precomputed_holidays` a class method.
This was referenced Jun 6, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4 development (#61):
ExchangeCalendar.*_windowmethods to return windows of lengthcount(instead ofcount+ 1).Requested*OutOfBounds).ExchangeCalendarbound*anddefault*properties to class methods (related to Shouldn't calendar defintion methods/properties be class methods/attributes? #182).See commit messages for more further details.