Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skeleton loader for modal connecting state #70

Merged
merged 1 commit into from
Oct 3, 2023
Merged

feat: add skeleton loader for modal connecting state #70

merged 1 commit into from
Oct 3, 2023

Conversation

hirenchauhan2
Copy link
Contributor

Closes #34

@hirenchauhan2
Copy link
Contributor Author

Hi @rolznz,

I just noticed, you haven't added hacktoberfest topic on this project. Could you please add that topic to mark this PR accepted for Hacktoberfest?

@@ -60,7 +76,7 @@ export class Start extends withTwind()(BitcoinConnectElement) {
How would you like to connect?
</h1>

<bc-connector-list />
<bc-connector-list></bc-connector-list>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this too 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this when I ran npm run lint. The other error was in the test-file for my-component. I was not sure what do there hence did not fixed that.

Copy link
Collaborator

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, great job!

@rolznz
Copy link
Collaborator

rolznz commented Oct 3, 2023

@hirenchauhan2 thanks very much. I added the hacktoberfest and hacktoberfest2023 tags to the project

@rolznz
Copy link
Collaborator

rolznz commented Oct 3, 2023

@hirenchauhan2 do you have a bitcoin lightning address and nostr account?

We will consider you for a top Alby contributor for this year's hacktoberfest

CC @itstomekk

@rolznz rolznz merged commit 8be41d9 into getAlby:master Oct 3, 2023
@hirenchauhan2
Copy link
Contributor Author

hirenchauhan2 commented Oct 3, 2023

@rolznz , unfortunately no. I'm not into Bitcoin/crypto. Have lost a lot into that 😭

And thank you for considering me as top contributor! It's a great pleasure to be part of OSS community!🥳

@MoritzKa
Copy link
Contributor

MoritzKa commented Oct 3, 2023

No worries. There are indeed some bad crypto projects out there. It is even more remarkable that you made this PR. 🙌

@hirenchauhan2
Copy link
Contributor Author

Let me know if you need any help on the front-end side. I'll do my best!

@hirenchauhan2 hirenchauhan2 deleted the add-skeleton-loader branch October 3, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add skeleton loader for modal connecting state
3 participants