-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add skeleton loader for modal connecting state #70
Conversation
Hi @rolznz, I just noticed, you haven't added |
@@ -60,7 +76,7 @@ export class Start extends withTwind()(BitcoinConnectElement) { | |||
How would you like to connect? | |||
</h1> | |||
|
|||
<bc-connector-list /> | |||
<bc-connector-list></bc-connector-list> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing this too 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw this when I ran npm run lint
. The other error was in the test-file for my-component
. I was not sure what do there hence did not fixed that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK, great job!
@hirenchauhan2 thanks very much. I added the hacktoberfest and hacktoberfest2023 tags to the project |
@hirenchauhan2 do you have a bitcoin lightning address and nostr account? We will consider you for a top Alby contributor for this year's hacktoberfest CC @itstomekk |
@rolznz , unfortunately no. I'm not into Bitcoin/crypto. Have lost a lot into that 😭 And thank you for considering me as top contributor! It's a great pleasure to be part of OSS community!🥳 |
No worries. There are indeed some bad crypto projects out there. It is even more remarkable that you made this PR. 🙌 |
Let me know if you need any help on the front-end side. I'll do my best! |
Closes #34