feat: add lookup invoice to nwc webln provider #73
Conversation
src/webln/NostrWeblnProvider.ts
Outdated
| @@ -214,7 +224,7 @@ export class NostrWebLNProvider implements WebLNProvider, Nip07Provider { | |||
| // TODO: use NIP-47 get_info call | |||
| async getInfo(): Promise<GetInfoResponse> { | |||
| return { | |||
| methods: ["getInfo", "sendPayment", "addinvoice", "getBalance"], | |||
| methods: ["getInfo", "sendPayment", "addinvoice", "getBalance", "lookupinvoice"], | |||
There was a problem hiding this comment.
we have sendPayment, so this should probably be lookupInvoice
also addinvoice should probably be makeInvoice
There was a problem hiding this comment.
@bumi thanks for confirming, I got a bit confused here.
The ones I put are LND methods, but then we also have the official WebLN methods.
There was a problem hiding this comment.
@bumi I have updated webln-types and fixed those inconsistencies. Thanks!
src/webln/NostrWeblnProvider.ts
Outdated
|
|
||
| return this.executeNip47Request<LookupInvoiceResponse>( | ||
| "lookup_invoice", | ||
| "lookupinvoice", |
There was a problem hiding this comment.
do we actually need to pass the two here? or can this be some mapping?
this is only needed for the events, isn't it?
There was a problem hiding this comment.
@bumi the webln request method is needed for the notification function. WebLN and NWC event names are inconsistent, I think we need to provide both.
Unless we can guarantee the only change is in casing, then we could have a mapping function from camelCase to lower_case_with_underscores
There was a problem hiding this comment.
but can't we do a mapping from
a = {
"lookup_invoice" : "lookupinvoice"
}
a["lookup_invoice"]
that then can be checked?
this is not actually a webln method. Not sure what to do here.