[WIP] LNURL pay #141
[WIP] LNURL pay #141
Conversation
|
wondering if we should just call it |
|
@bumi makes sense! |
src/extension/inpage-script/index.js
Outdated
| import Donation from "./donation"; | ||
|
|
||
| if (document) { | ||
| window.webln = new WebLNProvider(); | ||
| window.lnurl = new LNURLProvider(); |
There was a problem hiding this comment.
actually I think we should stick with WebLN here and propose a new lnul function on the webln object.
so if it is a lnurl link we call the webln.lnurl() function which sends the message to lnurl action. There we decode the lnurl, do the GET request and then continue depending on the type of the lnurl (pay, auth, etc.)
what do you think?
There was a problem hiding this comment.
The lnurl action sounds good to me. (Moving the decoding and GET away from React) I'm only not sure about if lnurl should be part of webln as they are different directions?
There was a problem hiding this comment.
yes, that needs to be discussed. Though I am not sure if it is different directions. WebLN describes a way how to interact with lightning from the web/JS.
Instead of passing a lightning invoice we are passing in a lnurl.
(somewhat related discussion around extending webln with keysend: joule-labs/webln#33)
src/app/screens/LNURLPay.tsx
Outdated
| try { | ||
| // Get the invoice | ||
| const params = { | ||
| amount: value, // user specified sum in MilliSatoshi |
There was a problem hiding this comment.
we have to be careful here currently we use satoshis but we get MilliSatoshi here.
|
|
||
| // Once payment is fulfilled LN WALLET executes a non-null successAction | ||
| // LN WALLET should also store successAction data on the transaction record | ||
| if (successAction) { |
There was a problem hiding this comment.
wondering if we should handle the successAction in the component?
displaying the URL (with link to open) and the decrypted message could be easier in the component? or we have to open another prompt?
There was a problem hiding this comment.
@bumi Yes indeed, was already planning to move this to the component. That way we can easily show custom modals etc.
A decrypted account is only available after the prompt. If the account is not unlocked the prompt asks for the password and unlocks the account
(LIGHTNING: vs. lightning:)
To auto-login we need to make sure the account is unlocked. Otherwise we need to show the prompt which handles unlocking
src/app/screens/LNURLPay.tsx
Outdated
| successCallback, | ||
| // Once payment is fulfilled LN WALLET executes a non-null successAction | ||
| // LN WALLET should also store successAction data on the transaction record | ||
| successCallback: successAction |
There was a problem hiding this comment.
interesting, didn't even think of passing a function through those calls. good that it works.
src/app/screens/LNURLPay.tsx
Outdated
| <div className="p-6"> | ||
| <dl className="shadow p-4 rounded-lg mb-8"> | ||
| <dt className="font-semibold text-gray-500">Send payment to</dt> | ||
| <dd className="mb-6">{origin.name}</dd> |
There was a problem hiding this comment.
here we should also display details.url.host
|
whoa! yay! let's merge it, the missing parts we can improve in new PRs. |
Can be tested with: https://lnurl.fiatjaf.com/
TODO: