Fix batching for nested flatmaps at different levels of composition #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Implementation note: this test will fail if ClumpContext::getClumpsByLevel does not satisfy the requirement that | ||
| // "Clumps appear as early in the list as possible" | ||
| "for clumps created inside nested flatmaps at different levels of composition" in new Context { | ||
| val clump1 = Clump.value(1).flatMap(source1.get).flatMap(source2.get).map(identity) |
There was a problem hiding this comment.
Adding the .map(identity) here used to make it quit correctly batching requests after the first one. It would still get the right answer but it was doing too many calls to the source.
|
@fwbrasil @williamboxhall - look good to you? |
|
👍 |
stevenheidel
added a commit
that referenced
this pull request
Sep 15, 2015
Fix batching for nested flatmaps at different levels of composition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A coworker found an edge case that meant we weren't optimally batching in the flushDownstream method. I had to make the
getClumpsByLevela bit more sophisticated to handle this.