Add a couple inferred methods and aliases to clump api

[stevenheidel]

The most useful of these to me is default. I want to be able to go:

for {
  list <- clumpSourceThatReturnsList.get(id).default(Nil)
} yield {
  // code
}

instead of having to do this all the time:

for {
  listOption <- clumpSourceThatReturnsList.get(id).optional
} yield {
  val list = listOption.getOrElse(Nil)
  // code
}

[williamboxhall]

Interesting point @stevenheidel.

Do you think it could be easier to use

clumpSourceThatReturnsList.get(id).orElse(Clump.value(Nil))

Or if you don't like wrapping up the Nil in a clump every time, maybe it would be good to have a getOrElse on the ClumpSource interface?

clumpSourceThatReturnsList.getOrElse(id, Nil)

[fwbrasil]

To keep a behavior similar to Future.apply[0], this method should propagate exceptions inside a Clump instance. Suggestion:

def apply[T](value: => T): Clump[T] = this.future(Future(value))

Same observation for the next method.

[0] https://github.com/scala/scala/blob/2.11.x/src/library/scala/concurrent/Future.scala#L492

[stevenheidel]

Fixed, thanks!

[stevenheidel]

@williamboxhall - clumpSourceThatReturnsList.get(id).orElse(Clump.value(Nil)) works, but it's kind of silly to wrap the Nil in a Clump. I supposed that's made slightly easier by the .apply method so you could write clumpSourceThatReturnsList.get(id).orElse(Clump(Nil))

I like your suggestion for a .getOrElse though.

[stevenheidel]

This is what .getOrElse would look like on ClumpSource:

  def getOrElse(input: T, default: => U): Clump[U] =
    get(input).orElse(Clump(default))

[fwbrasil]

About Clump.value vs Clump[Option[T]]. The usage of an option inside a Clump instance is a feature for corner cases where we want to avoid lossy joins. The Clump result is already optional. Given this, I think the current alternative is satisfactory:

val clump: Clump[Option[T]] = Clump.value(someValue).optional

[fwbrasil]

@williamboxhall I wouldn't like to pollute the ClumpSource interface with transformation methods (getOrElse). I think the Clump's interface should be expressive enough so we have only one way of applying transformations.

[stevenheidel]

@fwbrasil - thanks, renamed default to orElse using ClassTag.

[fwbrasil]

@stevenheidel Thanks, could you add tests for the new methods?

[stevenheidel]

@fwbrasil - Added tests for fallback, fallbackTo, and orElse. How would you like me to test the methods that are just synonyms? I don't really want to just copy the tests from the other methods.

[fwbrasil]

@stevenheidel Please add tests for all methods, we aim to keep the 100% code coverage.

[stevenheidel]

@fwbrasil - For the tests that are just synonyms of other methods do you want me to just copy the tests?

[fwbrasil]

@stevenheidel The test needs to check that the synonyms are pointing to the correct methods and passing the correct params. It is ok to copy an existing test if it tests the synonym properly.

[fwbrasil]

Thanks @stevenheidel!

👍 cc/ @williamboxhall

[williamboxhall]

nice

[williamboxhall]

👍 some nice additions