Change ClumpSource/Fetcher to honour call order #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| private[getclump] final class ClumpFetcher[T, U](source: ClumpSource[T, U]) { | ||
|
|
||
| private[this] val fetches = MutableMap[T, Promise[Option[U]]]() | ||
| private[this] val fetches = mutable.LinkedHashMap[T, Promise[Option[U]]]() |
There was a problem hiding this comment.
Could you explain this change?
There was a problem hiding this comment.
I mean, why do you need LinkedHashMap?
There was a problem hiding this comment.
Because it retains insertion order. From the docs:
The iterator and all traversal methods of this class visit elements in the order they were inserted.
There was a problem hiding this comment.
The map is used only as a temporary cache and we don't iterate over it. I can't see why the change is necessary.
There was a problem hiding this comment.
we do end up iterating over it, see changing in pendingFetches
There was a problem hiding this comment.
I see now, thanks for the clarification. :)
fwbrasil
added a commit
that referenced
this pull request
May 25, 2015
Change ClumpSource/Fetcher to honour call order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fwbrasil