Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos found by codespell #65

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Nov 15, 2023

You won't be able to see the changes in the JSON file online, it's a huge 2.1 MB one-liner.

To see the changes, do as follows:

$ git checkout main
$ python3 -m json.tool geteduroam/discovery.json  > geteduroam/discovery.json.OLD
$ 
$ git checkout codespell
$ python3 -m json.tool geteduroam/discovery.json  > geteduroam/discovery.json.NEW
$ 
$ diff geteduroam/discovery.json.OLD geteduroam/discovery.json.NEW 
2811c2811
<                     "any": "Opole University of Technnology",
---
>                     "any": "Opole University of Technology",
2893c2893
<                     "any": "Technical Univeristy of Lodz",
---
>                     "any": "Lodz University of Technology",
30604c30604
<                     "en": "Academy of Perfoming Arts in Prague"
---
>                     "en": "Academy of Performing Arts in Prague"
40535c40535
<                     "any": "Wroclaw University of Enviromental and Life Sciences",
---
>                     "any": "Wroclaw University of Environmental and Life Sciences",
75640c75640
<                     "any": "Univeristy of Kelaniya"
---
>                     "any": "University of Kelaniya"
77618c77618
<                     "any": "Faculty of Medicine, Univeristy of Kelaniya"
---
>                     "any": "Faculty of Medicine, University of Kelaniya"
$ 

Rationale for the changes in the JSON file:

  • Opole University of Technology: it's Technology, not Technnology
  • Lodz University of Technology: it's University, not Univeristy, plus the name in English is Lodz University of Technology on their web site
  • Academy of Performing Arts in Prague: it's Performing, not Perfoming
  • Wroclaw University of Environmental and Life Sciences: it's Environmental, not Enviromental
  • University of Kelaniya: it's University, not Univeristy

@pauldekkers
Copy link
Member

The JSON file is basically a cached version of what is provided by the institutions themselves via eduroam CAT. That's really the place where the institution administrators should fix these values. Making these modifications in the repository here does not make sense.

@DimitriPapadopoulos
Copy link
Contributor Author

Is there a way for a 3rd party to suggest changes, or are changes exclusively initiated by the administrators of either site?

@DimitriPapadopoulos
Copy link
Contributor Author

I reverted the change to the JSON file.

@johankool
Copy link
Collaborator

Thanks @DimitriPapadopoulos

@johankool johankool merged commit 3f5dbcb into geteduroam:main Nov 27, 2023
@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch November 27, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants