Improve response handling and username / password dialog #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IuliaSTANA
reviewed
Oct 19, 2023
| @@ -42,6 +47,7 @@ fun UsernamePasswordDialog( | |||
| var username by remember { mutableStateOf("") } | |||
There was a problem hiding this comment.
Just a Compose FYI, you can also deconstruct the remember into its state and lambda like this:
val (username, onUsernameChange) = remember { mutableStateOf("") }
and then directly use them
OutlinedTextField(
value = username,
onValueChange = onUsernameChange,
)
especially in you don't do anything extra in the onValueChange. I always thought it was kind of neat, never did get to use it
IuliaSTANA
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.