Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XSD validation #39

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add XSD validation #39

wants to merge 1 commit into from

Conversation

jornane
Copy link
Member

@jornane jornane commented Aug 14, 2022

Before reading an eap-config profile, verify the XSD. This prevents loading profiles that do not match the XSD, this may in some cases be a bit too strict, but on the other hand it prevents issues like #38.

The XSD is copied from the CAT project, and modified.

  • Add Username field (besides existig UserName field)
  • Fix whitespace (tabs and remove tailing whitespace)

The Username field is not used by this application. However, refusing it would yield problems with keeping compatibility with the current Android app.

An issue that could occur when merging this code, is that the XSD often specifies a sequence, which mandates a certain ordering in the eap-config file. Current we do not care about this ordering, but we would if this was merged.

For example, this would be valid:

<IEEE80211>
<SSID>eduroam</SSID>
<MinRSNProto>CCMP</MinRSNProto>
</IEEE80211>

but this would not:

<IEEE80211>
<MinRSNProto>CCMP</MinRSNProto>
<SSID>eduroam</SSID>
</IEEE80211>

@jornane jornane marked this pull request as draft August 23, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant