Rename file_based_screen_grabber to custom_screenshot_writer getgauge…

…/gauge#1476

getgauge/python.py

@@ -56,17 +56,17 @@ def after_step(obj=None):
 
 
 def screenshot(func):
-    _warn_screenshot_deprecation('screenshot', 'file_based_screen_grabber')
+    _warn_screenshot_deprecation('screenshot', 'custom_screenshot_writer')
     registry.set_screenshot_provider(func, False)
     return func
 
 
 def custom_screen_grabber(func):
-    _warn_screenshot_deprecation('custom_screen_grabber', 'file_based_screen_grabber')
+    _warn_screenshot_deprecation('custom_screen_grabber', 'custom_screenshot_writer')
     registry.set_screenshot_provider(func, False)
     return func
 
-def file_based_screen_grabber(func):
+def custom_screenshot_writer(func):
     registry.set_screenshot_provider(func, True)
     return func
 

getgauge/registry.py

@@ -107,7 +107,7 @@ class Registry(object):
 
     def __init__(self):
         self.__screenshot_provider, self.__steps_map, self.__continue_on_failures = _take_screenshot, {}, {}
-        self.is_file_based_screenshot = True
+        self.is_screenshot_writer = True
         for hook in Registry.hooks:
             self.__def_hook(hook)
 
@@ -151,9 +151,9 @@ def get_info_for(self, step_text):
     def get_infos_for(self, step_text):
         return self.__steps_map.get(step_text)
 
-    def set_screenshot_provider(self, func, is_file_based):
+    def set_screenshot_provider(self, func, is_writer):
         self.__screenshot_provider = func
-        self.is_file_based_screenshot = is_file_based
+        self.is_screenshot_writer = is_writer
 
     def screenshot_provider(self):
         return self.__screenshot_provider
@@ -260,7 +260,7 @@ def capture():
 
     @staticmethod
     def capture_to_file():
-        if not registry.is_file_based_screenshot:
+        if not registry.is_screenshot_writer:
             screenshot_file = _uniqe_screenshot_file()
             content = registry.screenshot_provider()()
             file = open(screenshot_file, "w")

tests/test_python.py

@@ -513,7 +513,7 @@ def test_screenshot_decorator(self):
 class ScreenshotsTests(TestCase):
     def setUp(self):
         self.__old_screenshot_provider = registry.screenshot_provider()
-        self.__is_file_based_screenshot = registry.is_file_based_screenshot
+        self.__is_screenshot_writer  = registry.is_screenshot_writer
         os.environ["screenshots_dir"] = tempfile.mkdtemp()
 
     def test_pending_screenshots(self):
@@ -570,7 +570,7 @@ def returns_base_ath():
 
     def tearDown(self):
         registry.set_screenshot_provider(
-            self.__old_screenshot_provider, self.__is_file_based_screenshot)
+            self.__old_screenshot_provider, self.__is_screenshot_writer)
 
 
 if __name__ == '__main__':