Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new step implementation in a new file - the step is shown as unimplemented #1308

Closed
sswaroopgupta opened this issue Dec 6, 2018 · 5 comments
Assignees

Comments

@sswaroopgupta
Copy link
Contributor

sswaroopgupta commented Dec 6, 2018

Expected behavior
Add a new step implementation in a new file - the step is shown as implemented

Actual behavior
Add a new step implementation in a new file - the step is shown as unimplemented

Steps to replicate

  • Create a gauge-java project
  • Add a new step
  • Give the implementation in a new file
  • Go back to the spec file
  • Close the impl file.
  • Go back to the spec file
  • The step is shown as unimplemented

Version

Gauge version: 1.0.4.nightly-2018-12-03
Commit Hash: 62a48e5

Plugins
-------
java (0.7.0.nightly-2018-12-04)

Related issue getgauge/gauge-vscode#83

@Apoorva-GA Apoorva-GA assigned Apoorva-GA and unassigned Apoorva-GA Dec 13, 2018
@shubhamsc shubhamsc self-assigned this Dec 19, 2018
@negiDharmendra
Copy link
Contributor

This issue is not just related to gauge-java, I can replicate this issue with gauge-js as well.
Something has changed(not sure yet, what that change is) either in VSCODE or VSCODE LSP client. Due to which the events our LSP server receives from vscode are not in the correct order while creating step implementation in the new file.

Expected order of events

  1. textDocument/didOpen
  2. workspace/didChangeWatchedFiles
  3. textDocument/didChange
    which is correct in vscode-jsonrpc(3.6.0), vscode-languageclient(4.0.0) and vscode-languageserver-protocol(3.6.0)

Actual order of events

  1. textDocument/didOpen
  2. textDocument/didChange
  3. workspace/didChangeWatchedFiles
    vscode-jsonrpc => 4.0.0
    vscode-languageclient => 5.1.1
    vscode-languageserver-protocol => 3.13.0

I have raised an issue on the vscode language server node.

@sswaroopgupta sswaroopgupta transferred this issue from getgauge/gauge-java Jan 16, 2019
@nehashri nehashri added ready and removed triage labels Jan 16, 2019
@nehashri nehashri assigned nehashri and unassigned negiDharmendra Jan 16, 2019
nehashri pushed a commit to getgauge/gauge-java that referenced this issue Jan 16, 2019
nehashri pushed a commit to getgauge/gauge-js that referenced this issue Jan 18, 2019
nehashri pushed a commit to getgauge/gauge-python that referenced this issue Jan 22, 2019
nehashri pushed a commit to getgauge/gauge-ruby that referenced this issue Jan 22, 2019
@getgauge getgauge deleted a comment from sswaroopgupta Jan 22, 2019
nehashri pushed a commit to getgauge/gauge-dotnet that referenced this issue Jan 23, 2019
@nehashri
Copy link
Contributor

nehashri commented Jan 23, 2019

To fix this, there needs to be a change in the implementation of these requests in the runner. Here is a list of runners which support lsp protocol as of now and the PR's raised against them. This issue needs to be verified against each of these

Langauge Nightly Date Verified
Java >= 17-01-2019
JavaScript >= 18-01-2019
Python >= 01-02-2019
Ruby >= 23-01-2019
.Net core >= 29-01-2019

@Debashis9012
Copy link
Contributor

This is reproducible for dotnet language.

Gauge version: 1.0.5.nightly-2019-02-15
Commit Hash: 48d032f

Plugins
-------
dotnet (0.1.2.nightly-2019-02-14)

@gaugebot
Copy link

gaugebot bot commented Feb 21, 2019

The fix should be available in nightly >= 21-2-2019

@Debashis9012
Copy link
Contributor

This has been verified against the below version.
1.0.5.nightly-2019-02-22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants