Properly handle Collections that specify a custom key, rather than fa…

…lling back to indexed list (#632)
getgrav · Jun 1, 2016 · d3b33fb · d3b33fb
1 parent ae08766
commit d3b33fb
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 16 deletions.
diff --git a/themes/grav/app/forms/fields/collections.js b/themes/grav/app/forms/fields/collections.js
@@ -68,20 +68,32 @@ export default class CollectionsField {
         items.each((index, item) => {
             item = $(item);
             let observed = item.find('[data-key-observe]');
+            let observedValue = observed.val();
             let hasCustomKey = observed.length;
             let currentKey = item.data('collection-key-backup');
 
-            item.attr('data-collection-key', hasCustomKey ? observed.val() : index);
+            item.attr('data-collection-key', hasCustomKey ? observedValue : index);
 
             ['name', 'data-grav-field-name', 'for', 'id'].forEach((prop) => {
-                item.find('[' + prop + ']').each(function() {
+                item.find('[' + prop + '], [_' + prop + ']').each(function() {
                     let element = $(this);
                     let indexes = [];
                     let regexps = [
                         new RegExp('\\[(\\d+|\\*|' + currentKey + ')\\]', 'g'),
                         new RegExp('\\.(\\d+|\\*|' + currentKey + ')\\.', 'g')
                     ];
 
+                    if (!observedValue) {
+                        element.attr(`_${prop}`, element.attr(prop));
+                        element.attr(prop, null);
+                        return;
+                    }
+
+                    if (element.attr(`_${prop}`)) {
+                        element.attr(prop, element.attr(`_${prop}`));
+                        element.attr(`_${prop}`, null);
+                    }
+
                     element.parents('[data-collection-key]').map((idx, parent) => indexes.push($(parent).attr('data-collection-key')));
                     indexes.reverse();