Admin Charts Constantly Updating

[chryton]

It appears that the interval is not being cleared upon completion of the cart update and it is causing divs to be constantly updated: http://rocketgoatin.space/jetsam/N51TyVJ2ja/

[rhukster]

@flaviocopes you mind looking at this one?

[flaviocopes]

Checking

[flaviocopes]

I don't know how we missed this performance issue. I tracked the problem down to 8bd7f8d, which is fixing this issue #753.

So there is this loop:

// Sidebar auto-refresh
global.setInterval(() => {
    contentScrollbar.update();
    sidebar.scroller.update();
    Object.keys(Dashboard.Chart.Instances).forEach((chart) => {
        Dashboard.Chart.Instances[chart].chart.update();
    });
}, 150);

The charts refresh every 150ms. This is a comparison of doing the interval every 150ms, then every 2s, then every 10s:

Quite a deal. I am unsure how to fix this problem while avoiding the original problem to come up again. We can start by relaxing the graph refresh interval to 2s, so the graphs are refreshed upon various UI changes, but not as much frequently, but we need to figure out a better way to detect those changes.

[flaviocopes]

Actually, I'm testing removing the JS altogether and I don't think we need those chart refreshes any more. Seems some recent CSS change is already fixing the issue mentioned in #753. I'm going to remove that JS in a PR so you can test as well.

[flaviocopes]

I have pushed a fix in develop, which removes the JS refresh of the graphs. Is anyone able to replicate the issues listed in #753? I could not with Chrome / Firefox