Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup button doesn't work with semicolon separator #1602

Closed
tranduyhung opened this issue Jan 30, 2019 · 3 comments
Closed

Backup button doesn't work with semicolon separator #1602

tranduyhung opened this issue Jan 30, 2019 · 3 comments
Labels
bug

Comments

@tranduyhung
Copy link

I have Grav v1.5.7 and Admin v1.8.16. Click Backup button in Admin's dashboard and nothing happens.

There is no JavaScripts errors, there is no AJAX requests to the server.

If I access the backup URL directly (eg domain.com/admin/backup.json/task;backup/admin-nonce;XYZ), the backup is made successfully.

So the problem seems from the front-end side of Admin plugin.
@rhukster
Copy link
Member

This is completely rewritten for grav 1.6 and admin 1.9.

@rhukster rhukster changed the title Backup button does nothing Backup button doesn't work with semicolon separator Feb 2, 2019
@rhukster rhukster added the bug label Feb 2, 2019
@lufog
Copy link
Contributor

lufog commented Feb 5, 2019

Yep
#1502

w00fz added a commit that referenced this issue Feb 5, 2019
@w00fz
Fixed hardcoded separators for backup and media picker (fixes #1602 , f…
bfb0b8e 
…ixes #1502)
@w00fz
Copy link
Member

w00fz commented Feb 5, 2019

Fixed in 1.9, cheers.

@w00fz w00fz closed this as completed Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@w00fz @tranduyhung @rhukster @lufog