Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added field.outerclasses #1124

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Added field.outerclasses #1124

merged 2 commits into from
Jun 27, 2017

Conversation

paulmassen
Copy link
Contributor

Added field.outerclasses to match the common field attributes in the docs.

It seems to me we can remove field.field_classes too but some plugin might depend on it.

@paulmassen
Added field.outerclasses
60e0461 
Added field.outerclasses to match the common field attributes in the docs.

It seems to me we can remove field.field_classes too but some plugin might depend on it.
@flaviocopes flaviocopes mentioned this pull request Jun 1, 2017
Closed
flaviocopes
flaviocopes suggested changes Jun 1, 2017
View reviewed changes
Copy link
Contributor

@flaviocopes flaviocopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can have both to make this compatible with frontend forms, although there's a duplicate field for classes.

But add a space before the twig, or it will show concatenated to form-field-toggleable

@rhukster rhukster merged commit 1fa667a into getgrav:develop Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviocopes flaviocopes flaviocopes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulmassen @flaviocopes @rhukster