Limit Parents Levels #1298
Merged
Limit Parents Levels #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, will be in next release |
rhukster
pushed a commit
that referenced
this pull request
Jan 19, 2018
* Adding parents levels limit * Adding parents levels limit
Flamenco
pushed a commit
to Flamenco/grav-plugin-admin
that referenced
this pull request
Mar 15, 2018
* Adding parents levels limit * Adding parents levels limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main beneffit of this PR is to improve the parent selection when you have many pages.
This PR will add a field in blueprint and a limit var to the
parentsfield in order to limit the levels of parents to show in admin forms. The parent levels limit filter was already implemented inpagesfield, so there was not much to change to make it work.Solves part or act as a workarround for these issues:
#735, #902, #906, #941, #1035
In the future, this might be improved adding low and high level limits. Also having parents filter by page type would be great, or even adding a header
parent: falseby page basis. But for now this PR helps.