Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding inline notices, to use inside tables #10

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

miguelsalespereira
Copy link
Contributor

Besides the default behaviour, with this change, we can also the notices inside markdown tables as follow:

Information Note Warning
! Information here !!! Note here !!!! Warning here
Other content Other content Other content

Besides the default behaviour, with this change, we can also the notices inside markdown tables as follow:

| Information | Note | Warning |
| :----- | :----- | :----- |
| ! Information here | !!! Note here | !!!! Warning here |
| Other content | Other content | Other content |
@miguelsalespereira
Copy link
Contributor Author

Example of parsed page before and after this change (visible styles are applied from our theme and not the default ones from the plugin)

before

before-pull-request

after

after-pull-request

@rhukster rhukster merged commit d1d28f4 into getgrav:develop Aug 9, 2019
rhukster added a commit that referenced this pull request Aug 16, 2019
rhukster added a commit that referenced this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants