-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple plugins updates often leads to "Fetch failed" error #1301
Comments
I also get this error quite often, using MAMP locally on a Mac. |
@flaviocopes you have mamp, ever seen this? I've never had a problem with my apache setup. |
Yes, I can confirm. Had this issue just now on latest Grav/Admin/Form Update |
Which browser are you using? Firefox? |
Yes, Firefox 51.0.1. |
Yes Firefox 51.0.1 (64 bit) for me too on Windows 10. |
I most often use Firefox (Mac) when testing locally too. |
This looks like a Firefox issue - could not replicate in Chrome, but I could replicate it on Firefox. |
The problems seems to be that on Firefox, the Fetch network calls are failing (not returning a 200), while on Chrome they do. This seems to me a Fetch implementation issue, or quirk, as the same issue can be seen on Firefox by clicking on the Dashboard "Check for updates", and then click something else: a red "Fetch error" appears, because the Fetch request is immediately closed with no 200 return code. @w00fz could this be possible? I see FF supports Fetch natively, so it's not a polyfill problem. |
I'll look into this |
This is now fixed with getgrav/grav-plugin-admin@b5384a4. The issue was that for each plugin getting updated, the callback was invoked. This caused confusion in Firefox probably because the callback includes a window reload. It might also explain the issue we had with the admin after updating plugins, where some of them didn't show as updated. A couple months back I was forced to set a timeout before refreshing to fix this. (getgrav/grav-plugin-admin@f547781#diff-f6fb147006cc04a8d7adc70c5f261972). I have now fixed the issue using Promises and only invoking the callback once when all the promises are fulfilled. Please give it a try. Btw for the future, admin issues should be filed under |
Thanks so much @w00fz and @flaviocopes! |
You're right! |
The issue has returned with an upgrade to Admin 1.3 running on XAMPP. |
@Duke3D which browser are you using? I can replicate this on Firefox, where it's annoying. Fetch raises an error whenever a network connection is active and you click away. The only way I found to stop this is to detect the error message, and if it's |
I'm again running into this issue, as described by Duke3D, as well. It has disappeared from my local environment, but I've taken the site online and there it occurs constantly (maybe network latency is relevant) – almost every click. Any ideas how to tackle this? The site is to be administrated by someone else, so this recurring flashing error message leaves a terrible impression. |
It's a tricky one because its only happening for very people folks and is almost certainly something related to how the server is setup/configured. It is probably some security software on the server or some configuration option that is limiting certain calls. I think the first thing to do is to try to contact your hosting provider and ask them about anything that could potentially interfering. |
I also have the problem: |
How about chrome? |
No, Chrome doesn't display the error message |
Edge (40.15063.0.0) and IE (v11.413.15063.0) also work fine. |
I don't have Gantry installed, but if you mash a bunch of the admin menus on the left, I was able to reproduce the error as well. |
This should be fixed now with getgrav/grav-plugin-admin@e0f9fd2 Cheers |
Testing locally use WAMPSERVER - I've found this on many of my local GRAV updates that I get a networkerror when doing multiple plugin updates and this can sometimes wreck site too. Single updates appear to work ok.
The text was updated successfully, but these errors were encountered: