-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenMediaVault widget #1807
OpenMediaVault widget #1807
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
When someone does all the work and makes a PR for it, and has enough interest. We'd have to come to some agreement on what required engagement from the community to constitute a "majority" looks like. Then given a "majority" of the community is interested in converting to TS; give the members a few weeks to review it, test it, etc., which would require a notice to freeze development until the review is complete and merged or otherwise. It would be a tremendous amount of effort, esp. given the number of widgets currently under maintenance. |
I just asked in the plan if there were any plans for this or something like that without pretensions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. A couple things:
- The widget should use normal "blocks", not implement its own style. We've come upon this issue before, but we prioritize consistency.
- Please revert the linting changes, it sorta muddies this PR
Also, since OMV setup isn't so trivial, if you could please provide some samples of API endpoints for testing, thanks.
Note: |
Thanks. Yea the text "block" widgets. |
Sorry, to clarify, they should be some version of e.g:, just like the downloader one
This is how fields filtering works and its the standard for all service widgets. I'll leave it up to you how to handle that, if you list the number of drives with SMART OK, services up / total, or whatever. Personally I would merge the widgets into one and support different fields (with a default limited to max 4 as in the guidelines). An example like this is the gamedig widget: https://github.com/benphelps/homepage/pull/1717/files |
alright |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you can use the charts or the standard ones. Im happy to merge this in the meantime if you’re good with it |
Hi @userXinos , would you mind sharing the code for pulling CPU & Memory usage. I am using OMV on a different system and would love to implement it. |
I don't have such code, can you see something similar in the glances widget? |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Proposed change
Widget for integration with OpenMediaVault (#1204)
OMV RPC docs: https://docs.openmediavault.org/en/6.x/development/tools/omv_rpc.html
Real docs: Source Code on GH
Type of change
Checklist:
pnpm lint
.