-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Switch to gojsonschema #318
base: master
Are you sure you want to change the base?
Conversation
0c797f4
to
87f951d
Compare
1c45c74
to
002f8ed
Compare
Signed-off-by: Pierre Fenoll <[email protected]>
002f8ed
to
6d81fa8
Compare
Signed-off-by: Pierre Fenoll <[email protected]>
Signed-off-by: Pierre Fenoll <[email protected]>
What is holding this PR back? I really need kin-openapi to properly validate nullable enums. :( |
@bhechinger From #230 we most probably will move to use https://github.com/qri-io/jsonschema instead of the lib in this PR. I didn't start work on this yet.. maybe give it a shot? |
@fenollp I'll take a look. If it's not going to be too much work to get done I may actually be able to make it a pre-req for my current task at work. :) |
Due to our current timeline crunch I won't have time for this right now. However, I was instructed to open a tech debt ticket to track this and come back to it later. If this hasn't been done by someone else in the next several months I will do it. |
Fixes incorrect schema validation:
Changes
format
support:Also: