openapi3filter: add context to Validator Middleware's ErrFunc and LogFunc functions #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for taking interest in this! Really, let's perpetrate the tiny API breakage this patch entails, please. As a solo maintainer I'm always happy to keep the API surface low. Also be sure to push the diffs from |
|
Thanks for your feedback! I implemented the changes as you suggested by updating the existing functions instead of creating new ones. Also, the |
fenollp
changed the title
fenollp
added a commit
to fenollp/kin-openapi
that referenced
this pull request
Jun 2, 2024
Signed-off-by: Pierre Fenoll <[email protected]>
fenollp
added a commit
that referenced
this pull request
Jun 2, 2024
Signed-off-by: Pierre Fenoll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature modifies the ErrFunc and LogFunc of the validator, just as described in #472
In contrast to the change described in the issue, this is not a breaking changes, since it adds additional functions to set the LogFunc and the ErrFunc instead of overwriting the existing ones.