openapi3: include local reference parts in refPath saved #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The local part was not included when visiting components during recursion * Also handles the case when base path is null when loading files data in memory * Copy uri.URL elements to avoid manipulation from outside source
fenollp
changed the title
fenollp
approved these changes
Jul 7, 2024
I thought you might ask :P, I will look at adding at least one direct test of the refPath of component references. There are a good amount of indirect tests (like internalise reference naming) but not for this particular case. I want to do that later today, we'll see if that happens |
|
Struggling to come up with test case, ideally we'd like to walk through the referenced components in a document. That almost involves re-implementing the resolving in loader.go. I think there are sufficent test cases for most the logic, up to you if you merge prior to additional tests for this specific case. I'll have to come back to this another time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug fix for code added in #955 for a seldom run code path with recursive refs