Remove roles count check from UserPermissions

getkirby · Sep 22, 2024 · 3e86173 · 3e86173
1 parent c96d47f
commit 3e86173
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/Cms/UserPermissions.php b/src/Cms/UserPermissions.php
@@ -39,7 +39,7 @@ protected function canChangeRole(): bool
 			return false;
 		}
 
-		return $this->model->roles()->count() > 1;
+		return true;
 	}
 
 	protected function canCreate(): bool

diff --git a/src/Panel/User.php b/src/Panel/User.php
@@ -70,7 +70,7 @@ public function dropdown(array $options = []): array
 			'dialog'   => $url . '/changeRole',
 			'icon'     => 'bolt',
 			'text'     => I18n::translate('user.changeRole'),
-			'disabled' => $this->isDisabledDropdownOption('changeRole', $options, $permissions)
+			'disabled' => $this->isDisabledDropdownOption('changeRole', $options, $permissions) || $this->model->roles('change')->count() < 2
 		];
 
 		$result[] = [

diff --git a/tests/Cms/Roles/RolesTest.php b/tests/Cms/Roles/RolesTest.php
@@ -151,7 +151,7 @@ public function testCanBeChanged()
 
 		$app->impersonate('[email protected]');
 		$canBeChanged = $roles->canBeChanged();
-		$this->assertCount(0, $canBeChanged); // TODO: change once `User::roles()` and `UserPermissions::canChangeRole()` have been improved/fixed
+		$this->assertCount(1, $canBeChanged);
 
 		$app->impersonate('[email protected]');
 		$canBeChanged = $roles->canBeChanged();

diff --git a/tests/Panel/UserTest.php b/tests/Panel/UserTest.php
@@ -275,7 +275,7 @@ public function testOptions()
 			'changeLanguage' => true,
 			'changeName'     => true,
 			'changePassword' => true,
-			'changeRole'     => false, // just one role
+			'changeRole'     => true,
 			'delete'         => true,
 			'update'         => true,
 		];