Role field: always use radio input

getkirby · Sep 7, 2024 · ee6c42b · ee6c42b
1 parent 3540d33
commit ee6c42b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 12 deletions.
diff --git a/src/Panel/Field.php b/src/Panel/Field.php
@@ -215,9 +215,10 @@ public static function role(
 		]);
 
 		return array_merge([
-			'label'   => I18n::translate('role'),
-			'type'    => count($roles) <= 1 ? 'hidden' : 'radio',
-			'options' => $roles
+			'label'    => I18n::translate('role'),
+			'type'     => count($roles) === 0 ? 'hidden' : 'radio',
+			'disabled' => count($roles) <= 1,
+			'options'  => $roles
 		], $props);
 	}
 

diff --git a/tests/Panel/FieldTest.php b/tests/Panel/FieldTest.php
@@ -221,9 +221,10 @@ public function testRole(): void
 	{
 		$field = Field::role();
 		$expected = [
-			'label'   => 'Role',
-			'type'    => 'hidden',
-			'options' => []
+			'label'    => 'Role',
+			'type'     => 'hidden',
+			'disabled' => true,
+			'options'  => []
 		];
 
 		$this->assertSame($expected, $field);
@@ -250,9 +251,10 @@ public function testRole(): void
 
 		$field = Field::role();
 		$expected = [
-			'label'   => 'Role',
-			'type'    => 'radio',
-			'options' => [
+			'label'    => 'Role',
+			'type'     => 'radio',
+			'disabled' => false,
+			'options'  => [
 				[
 					'text' => 'Client',
 					'info' => 'No description',
@@ -273,9 +275,10 @@ public function testRole(): void
 
 		$field = Field::role();
 		$expected = [
-			'label'   => 'Role',
-			'type'    => 'radio',
-			'options' => [
+			'label'    => 'Role',
+			'type'     => 'radio',
+			'disabled' => false,
+			'options'  => [
 				[
 					'text' => 'Admin',
 					'info' => 'Admin description',