Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user permissions: changeRole has no effect #5146

Closed
jaro-io opened this issue Apr 13, 2023 · 1 comment · Fixed by #6654
Closed

user permissions: changeRole has no effect #5146

jaro-io opened this issue Apr 13, 2023 · 1 comment · Fixed by #6654
Assignees

Comments

@jaro-io
Copy link

jaro-io commented Apr 13, 2023

hey there lovely kirby team 🌻
i am struggling with two things related to user permissions. i don’t know if they are related.
this is the other issue. feel free to merge if needed.

description

i would like to control what roles users with a certain role are allowed to change. for example a manager should be able to change roles for other users. but an assistant shouldn’t be able to do that. when i set the changeRole permissions to true or false in my user blueprints it doesn’t seem to have any effect.

also it seems like there is a difference between this doc and this doc. in the first one it seems like changeRole is only available for user, not users. in the second one it seems like it’s available for both.

Screenshot 2023-04-13 at 18 40 22

Screenshot 2023-04-13 at 18 38 58

to reproduce

start with a clean starterkit. add a new user blueprint with the following permissions.

permissions:
    user:
        delete: false # works, this user can’t delete itself
        changeRole: true # doesn’t work, this user can’t change its role
    users:
        changeRole: true # doesn’t work, this user can’t change other user’s roles

Screenshot 2023-04-13 at 18 27 13

your setup

kirby 3.9.3

thank you for your help!
🤍 ✨

@afbora
Copy link
Member

afbora commented Apr 13, 2023

I've wrote a comment about that #5147 (comment)

@distantnative distantnative self-assigned this Aug 11, 2024
distantnative added a commit that referenced this issue Aug 11, 2024
distantnative added a commit that referenced this issue Aug 11, 2024
distantnative added a commit that referenced this issue Aug 11, 2024
distantnative added a commit that referenced this issue Aug 31, 2024
distantnative added a commit that referenced this issue Aug 31, 2024
distantnative added a commit that referenced this issue Sep 7, 2024
distantnative added a commit that referenced this issue Sep 7, 2024
@distantnative distantnative linked a pull request Oct 12, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants