Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes: Simplified form controls #6697

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

bastianallgeier
Copy link
Member

@bastianallgeier bastianallgeier commented Sep 23, 2024

Description

Summary of changes

  • The form controls component is now stored in the Forms folder. There's no reason to have a subfolder as long as we don't have any other control components
  • The form controls go back to the original form button design, but with Discard instead of Revert
    Screenshot 2024-09-23 at 16 26 47
  • The component only has two states is-unsaved & is-locked
  • Additional information about the editor and modification time can be passed as additional arguments for the new lock dropdown
    Screenshot 2024-09-23 at 16 26 41

Todos

  • We might want to change the button color back to green or something else in a later step.
  • We also might want to change the "Save" icon and wording. But it's unclear at this point what it should be.

@distantnative distantnative merged commit 8103549 into v5/develop Sep 23, 2024
4 checks passed
@distantnative distantnative deleted the v5/changes/form-controls branch September 23, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants