feat(dunning): Add permission to analytics overdue balances

getlago · Sep 10, 2024 · e65bb30 · e65bb30
1 parent 6cf56be
commit e65bb30
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 3 deletions.
diff --git a/app/config/permissions/definition.yml b/app/config/permissions/definition.yml
@@ -1,5 +1,7 @@
 ---
 analytics:
+  overdue_balances:
+    view:
   view:
 billable_metrics:
   view:

diff --git a/app/config/permissions/role-finance.yml b/app/config/permissions/role-finance.yml
@@ -1,5 +1,7 @@
 ---
 analytics:
+  overdue_balances:
+    view: true
   view: true
 billable_metrics:
   view: false

diff --git a/app/config/permissions/role-manager.yml b/app/config/permissions/role-manager.yml
@@ -1,5 +1,7 @@
 ---
 analytics:
+  overdue_balances:
+    view: true
   view: false
 billable_metrics:
   view: false

diff --git a/app/graphql/resolvers/analytics/overdue_balances_resolver.rb b/app/graphql/resolvers/analytics/overdue_balances_resolver.rb
@@ -6,7 +6,7 @@ class OverdueBalancesResolver < Resolvers::BaseResolver
       include AuthenticableApiUser
       include RequiredOrganization
 
-      REQUIRED_PERMISSION = 'analytics:view'
+      REQUIRED_PERMISSION = 'analytics:overdue_balances:view'
 
       description 'Query overdue balances of an organization'
 

diff --git a/spec/graphql/resolvers/analytics/overdue_balances_resolver_spec.rb b/spec/graphql/resolvers/analytics/overdue_balances_resolver_spec.rb
@@ -3,7 +3,7 @@
 require 'rails_helper'
 
 RSpec.describe Resolvers::Analytics::OverdueBalancesResolver, type: :graphql do
-  let(:required_permission) { 'analytics:view' }
+  let(:required_permission) { 'analytics:overdue_balances:view' }
   let(:query) do
     <<~GQL
       query($currency: CurrencyEnum, $externalCustomerId: String, $months: Int, $expireCache: Boolean) {
@@ -24,7 +24,7 @@
 
   it_behaves_like 'requires current user'
   it_behaves_like 'requires current organization'
-  it_behaves_like 'requires permission', 'analytics:view'
+  it_behaves_like 'requires permission', 'analytics:overdue_balances:view'
 
   it 'returns a list of overdue balances' do
     result = execute_graphql(