Fix: change default value for WalletTransaction metadata (#2609)

All api clients expect metadata to be returned as array (and when
records are created, it's also an array), but if we create
WalletTransaction without metadata, it takes default value of `{}` which
then breaks api-clients

db/migrate/20240920084727_change_wallet_transactions_metadata_default.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+class ChangeWalletTransactionsMetadataDefault < ActiveRecord::Migration[7.1]
+  def up
+    change_column_default :wallet_transactions, :metadata, []
+    safety_assured do
+      execute <<-SQL
+        UPDATE wallet_transactions
+        SET metadata = '[]'::jsonb
+        WHERE metadata = '{}'::jsonb;
+      SQL
+    end
+  end
+
+  def down
+    change_column_default :wallet_transactions, :metadata, {}
+    safety_assured do
+      execute <<-SQL
+        UPDATE wallet_transactions
+        SET metadata = '{}'::jsonb
+        WHERE metadata = '[]'::jsonb;
+      SQL
+    end
+  end
+end

db/migrate/20240920091133_change_recurring_transaction_rules_transaction_metadata_default.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+class ChangeRecurringTransactionRulesTransactionMetadataDefault < ActiveRecord::Migration[7.1]
+  def up
+    change_column_default :recurring_transaction_rules, :transaction_metadata, []
+    safety_assured do
+      execute <<-SQL
+        UPDATE recurring_transaction_rules
+        SET transaction_metadata = '[]'::jsonb
+        WHERE transaction_metadata = '{}'::jsonb;
+      SQL
+    end
+  end
+
+  def down
+    change_column_default :recurring_transaction_rules, :transaction_metadata, {}
+    safety_assured do
+      execute <<-SQL
+        UPDATE recurring_transaction_rules
+        SET transaction_metadata = '{}'::jsonb
+        WHERE transaction_metadata = '[]'::jsonb;
+      SQL
+    end
+  end
+end

spec/services/wallets/create_interval_wallet_transactions_service_spec.rb

@@ -44,7 +44,7 @@
                 granted_credits: recurring_transaction_rule.granted_credits.to_s,
                 source: :interval,
                 invoice_requires_successful_payment: false,
-                metadata: {}
+                metadata: []
               }
             )
         end
@@ -80,7 +80,7 @@
                   granted_credits: recurring_transaction_rule.granted_credits.to_s,
                   source: :interval,
                   invoice_requires_successful_payment: false,
-                  metadata: {}
+                  metadata: []
                 }
               )
           end
@@ -111,7 +111,7 @@
                   granted_credits: "0.0",
                   source: :interval,
                   invoice_requires_successful_payment: false,
-                  metadata: {}
+                  metadata: []
                 }
               )
           end
@@ -136,7 +136,7 @@
                 granted_credits: recurring_transaction_rule.granted_credits.to_s,
                 source: :interval,
                 invoice_requires_successful_payment: false,
-                metadata: {}
+                metadata: []
               }
             )
         end
@@ -165,7 +165,7 @@
                   granted_credits: recurring_transaction_rule.granted_credits.to_s,
                   source: :interval,
                   invoice_requires_successful_payment: false,
-                  metadata: {}
+                  metadata: []
                 }
               )
           end
@@ -199,7 +199,7 @@
                   granted_credits: recurring_transaction_rule.granted_credits.to_s,
                   source: :interval,
                   invoice_requires_successful_payment: false,
-                  metadata: {}
+                  metadata: []
                 }
               )
           end
@@ -224,7 +224,7 @@
                 granted_credits: recurring_transaction_rule.granted_credits.to_s,
                 source: :interval,
                 invoice_requires_successful_payment: false,
-                metadata: {}
+                metadata: []
               }
             )
         end
@@ -253,7 +253,7 @@
                   granted_credits: recurring_transaction_rule.granted_credits.to_s,
                   source: :interval,
                   invoice_requires_successful_payment: false,
-                  metadata: {}
+                  metadata: []
                 }
               )
           end
@@ -277,7 +277,7 @@
                   granted_credits: recurring_transaction_rule.granted_credits.to_s,
                   source: :interval,
                   invoice_requires_successful_payment: false,
-                  metadata: {}
+                  metadata: []
                 }
               )
           end
@@ -302,7 +302,7 @@
                 granted_credits: recurring_transaction_rule.granted_credits.to_s,
                 source: :interval,
                 invoice_requires_successful_payment: false,
-                metadata: {}
+                metadata: []
               }
             )
         end
@@ -331,7 +331,7 @@
                   granted_credits: recurring_transaction_rule.granted_credits.to_s,
                   source: :interval,
                   invoice_requires_successful_payment: false,
-                  metadata: {}
+                  metadata: []
                 }
               )
           end
@@ -426,7 +426,7 @@
                 granted_credits: recurring_transaction_rule.granted_credits.to_s,
                 source: :interval,
                 invoice_requires_successful_payment: true,
-                metadata: {}
+                metadata: []
               }
             )
         end

spec/services/wallets/threshold_top_up_service_spec.rb

@@ -41,7 +41,7 @@
             granted_credits: "3.0",
             source: :threshold,
             invoice_requires_successful_payment: false,
-            metadata: {}
+            metadata: []
           }
         )
     end
@@ -132,7 +132,7 @@
               granted_credits: "0.0",
               source: :threshold,
               invoice_requires_successful_payment: false,
-              metadata: {}
+              metadata: []
             }
           )
       end