fix(stripe): nil result on small amount #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovrocolic
approved these changes
Jul 11, 2024
brunomiguelpinto
approved these changes
Jul 11, 2024
rsempe
approved these changes
Jul 11, 2024
abdussamadbello
pushed a commit
to abdussamadbello/lago-api
that referenced
this pull request
Aug 8, 2024
## Context In some cases on small invoice amount, the `Invoices::Payments::StripeCreateJob` is raising a `NoMethodError: undefined method `raise_if_error!' for nil` ## Description This PR fixes this issue by ensuring that a `result` is returned by the `Invoices::Payments::StripeCreateService`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In some cases on small invoice amount, the
Invoices::Payments::StripeCreateJobis raising aNoMethodError: undefined methodraise_if_error!' for nil`Description
This PR fixes this issue by ensuring that a
resultis returned by theInvoices::Payments::StripeCreateService