Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anrok): add model for error_details #2311

Merged
merged 18 commits into from
Jul 24, 2024

Conversation

annvelents
Copy link
Contributor

@annvelents annvelents commented Jul 19, 2024

Context

As part of implementation logic to store errors received from Anrok through Nango we need a new model that would be used to store the errors we got from integrations we have

Description

Added the model itself after the table has been added

@annvelents annvelents self-assigned this Jul 19, 2024
@annvelents annvelents force-pushed the ftr-anrok-add-integration-error-details-model branch 2 times, most recently from cf1a3ed to 06f2318 Compare July 22, 2024 13:48
@annvelents annvelents force-pushed the ftr-anrok-migration-create-integration-error-details branch from 9a8c6a7 to 9510b4a Compare July 23, 2024 08:41
@annvelents annvelents force-pushed the ftr-anrok-add-integration-error-details-model branch from e5efbbd to 9239619 Compare July 23, 2024 09:00
Base automatically changed from ftr-anrok-migration-create-integration-error-details to main July 23, 2024 09:09
@annvelents annvelents force-pushed the ftr-anrok-add-integration-error-details-model branch from 770bc42 to ea94965 Compare July 23, 2024 09:13
@annvelents annvelents marked this pull request as ready for review July 23, 2024 09:13
@julienbourdeau julienbourdeau changed the title feat(anrok): add model for integration_error_details feat(anrok): add model for error_details Jul 23, 2024
app/models/error_detail.rb Outdated Show resolved Hide resolved
spec/factories/error_details.rb Outdated Show resolved Hide resolved
Copy link
Collaborator

@lovrocolic lovrocolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Please take a look on the comment regarding integration association

@annvelents annvelents force-pushed the ftr-anrok-add-integration-error-details-model branch from 5356d72 to ad2d128 Compare July 23, 2024 15:46
@annvelents annvelents force-pushed the ftr-anrok-add-integration-error-details-model branch from ad2d128 to 44a0840 Compare July 23, 2024 15:58
@annvelents annvelents force-pushed the ftr-anrok-add-integration-error-details-model branch from 552c2e2 to 54b500e Compare July 23, 2024 16:43
@annvelents annvelents force-pushed the ftr-anrok-add-integration-error-details-model branch from 54b500e to 19b558f Compare July 23, 2024 16:58
@annvelents annvelents force-pushed the ftr-anrok-add-integration-error-details-model branch from 3a16de2 to a6b3adf Compare July 24, 2024 09:05
@annvelents annvelents merged commit b1204aa into main Jul 24, 2024
6 checks passed
@annvelents annvelents deleted the ftr-anrok-add-integration-error-details-model branch July 24, 2024 12:46
abdussamadbello pushed a commit to abdussamadbello/lago-api that referenced this pull request Aug 8, 2024
## Context

As part of implementation logic to store errors received from Anrok
through Nango we need a new model that would be used to store the errors
we got from integrations we have

## Description

Added the model itself after the table has been added

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants