Fix export invoices query object filters #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaseQuery `parse_datetime_filter` fails when a string date representation is parsed, even when the date format is "%Y-%m-%d". Given we work with times and dates in iso8601 format... we can use `DateTime.iso8601` method to parse dates, and date times with no errors.
from the graphQL invoices resolver from the REST API invoices controller and from the DataExports services given the filters are saved in a database fields and keys are converted into strings. Also, this change fixes the query performed for the CSV export as before was missing some filters that currently are outside of the filters hash.
ivannovosad
requested changes
Jul 24, 2024
use single quotes instead of double when no interpolation Co-authored-by: Ivan Novosad <[email protected]>
ivannovosad
approved these changes
Jul 24, 2024
abdussamadbello
pushed a commit
to abdussamadbello/lago-api
that referenced
this pull request
Aug 8, 2024
## Roadmap Task 👉 https://getlago.canny.io/feature-requests/p/ability-to-export-data-from-the-user-interface ## Description This change include a number of fixes related to query objects in general, the InvoicesQuery objects filters and how the invoices CSV export service uses the InvoicesQuery; * Fixes query objects date parsing capabilities as original implementation was able to parse datetimes and failed with dates. * Fix InvoicesQuery filters to ensure it works when keys are strings or symbols using the Filters object. * Fix DataExports::CSV::Invoices service to use properly the current InvoicesQuery interface as it was missing some filters that are currently outside of the filters hash (will be fixed in getlago#2313) --------- Co-authored-by: Ivan Novosad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roadmap Task
👉 https://getlago.canny.io/feature-requests/p/ability-to-export-data-from-the-user-interface
Description
This change include a number of fixes related to query objects in general, the InvoicesQuery objects filters and how the invoices CSV export service uses the InvoicesQuery;