Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: change format of error_details description we send to FE #2333

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

annvelents
Copy link
Contributor

Context

When adding error_details to the invoices PR, we added details of the errors as a jsonb object, while for now we'll be only storing there the error_code / error clarification and FE doesn't need the whole object for this

Description

Updated error_detail type to send only first value of it's detils

@annvelents annvelents self-assigned this Jul 25, 2024
@annvelents annvelents marked this pull request as ready for review July 25, 2024 09:57
@annvelents annvelents merged commit 09836b0 into main Jul 25, 2024
6 checks passed
@annvelents annvelents deleted the misc-update-error-details-type-on-invoice branch July 25, 2024 10:14
abdussamadbello pushed a commit to abdussamadbello/lago-api that referenced this pull request Aug 8, 2024
…go#2333)

## Context

When adding error_details to the invoices
[PR](getlago#2329), we added details of
the errors as a jsonb object, while for now we'll be only storing there
the error_code / error clarification and FE doesn't need the whole
object for this

## Description

Updated error_detail type to send only first value of it's detils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants