🐛 bug(ProgressiveBilling) Don't set recalculation flags to true when creating LifetimeUsage #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
changed the title
nudded
force-pushed
the
bug-fix-newly-created-lifetime-usage-no-recalculate
branch
from
abaa0f6
to
abaef07
Compare
lovrocolic
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
as we activate a subscription, we assumed we'd have to flag the life-time usage for recalculation. This is incorrect, and causes unneeded calculations. These flags should be set when an invoice is generated or an event is processed.